Use os.path.expanduser("~") instead of os.environ["HOME"]
#5398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On openQA staging, some code that runs `bodhi updates download` via `subprocess` was failing. Somehow in that context "HOME" wasn't in `os.environ`, so bodhi would crash, because it assumes that will be the case. This should make it more robust, by using os.path.expanduser instead. As documented: https://docs.python.org/3/library/os.path.html#os.path.expanduser it has fallback ways to get the path if the obvious one doesn't work. Signed-off-by: Adam Williamson <awilliam@redhat.com>
mattiaverga
force-pushed
the
client-expanduser
branch
from
8af1be0
to
d30f036
Compare
mattiaverga
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On openQA staging, some code that runs
bodhi updates downloadviasubprocesswas failing. Somehow in that context "HOME" wasn't inos.environ, so bodhi would crash, because it assumes that will be the case.This should make it more robust, by using os.path.expanduser instead. As documented:
https://docs.python.org/3/library/os.path.html#os.path.expanduser it has fallback ways to get the path if the obvious one doesn't work.