Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an endpoint to list critpath components #5484

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

mattiaverga
Copy link
Contributor

Let's have a way to provide information about what Bodhi consider to be in critical path.
WIP: I need to write some tests

@AdamWill If a user searches for collection=rawhide or collection=f40 we need the code to redirect to master.json. Do we have convenient symlinks set up? Otherwise I can do that in read_critpath_json

@AdamWill
Copy link
Contributor

AdamWill commented Sep 8, 2023

It's not master.json, it's rawhide.json. When you trace it all out, collection in this context is the git branch name. No, the script does not currently generate symlinks...I kinda don't mind whether we have the script create symlinks or just make read_critpath_json translate...

https://pagure.io/releng/blob/main/f/scripts/critpath.py#_345

@mattiaverga mattiaverga marked this pull request as ready for review September 17, 2023 15:57
@mattiaverga mattiaverga requested a review from a team as a code owner September 17, 2023 15:57
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
@mattiaverga mattiaverga merged commit 644acca into fedora-infra:develop Sep 18, 2023
27 of 29 checks passed
@mattiaverga mattiaverga deleted the critpath_endpoint branch September 18, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants