Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Fedora Messaging #12

Merged
merged 7 commits into from Apr 19, 2019
Merged

Migrate to Fedora Messaging #12

merged 7 commits into from Apr 19, 2019

Conversation

abompard
Copy link
Member

@abompard abompard commented Mar 1, 2019

Use the Fedora Messaging library, and migrate to stompest instead of the stomper-based moksha plugin.

Also, the app is Python3 now.

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
We're Python 3 now.
Also, add more stuff to .gitignore.

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
setup.py Outdated

setup(
name='bugzilla2fedmsg',
version='0.3.1',
description='Consume BZ messages over STOMP and republish to fedmsg',
version='0.4.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth bumping the major version since this isn't quite backward compatible?

@AdamWill
Copy link
Contributor

So, I just wrote a big PR to fix the processing of Bugzilla 5 messages:

#13

unfortunately it will conflict with this. The conflict shouldn't be too hard to resolve, though, once one or the other gets pushed we can adjust the other one.

@abompard
Copy link
Member Author

OK Adam, I'll bump the version in this one as suggested by @pypingou and then merge it. If you need help to resolve the conflicts in your PR, I can totally help.

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard abompard merged commit 057d047 into develop Apr 19, 2019
@abompard abompard deleted the fedora-messaging branch April 19, 2019 15:03
@AdamWill
Copy link
Contributor

I actually thought it'd be easier to merge them the other way around :( This one would probably only have one or two conflicting commits on top of mine, but I think all the commits in mine will conflict now this has changed where the affected code lives :( Oh well, I'll work through it.

@AdamWill
Copy link
Contributor

Is this 'stompest' thing not even packaged yet?

@AdamWill
Copy link
Contributor

Note this was missing a schema:

https://fedora-messaging.readthedocs.io/en/latest/messages.html#schema

We should add one; this should probably be done after my bz5 fixes PR is merged, because the schema would look different with and without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants