New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Fedora Messaging #12
Conversation
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
We're Python 3 now. Also, add more stuff to .gitignore. Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
setup.py
Outdated
|
||
setup( | ||
name='bugzilla2fedmsg', | ||
version='0.3.1', | ||
description='Consume BZ messages over STOMP and republish to fedmsg', | ||
version='0.4.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth bumping the major version since this isn't quite backward compatible?
So, I just wrote a big PR to fix the processing of Bugzilla 5 messages: unfortunately it will conflict with this. The conflict shouldn't be too hard to resolve, though, once one or the other gets pushed we can adjust the other one. |
OK Adam, I'll bump the version in this one as suggested by @pypingou and then merge it. If you need help to resolve the conflicts in your PR, I can totally help. |
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
I actually thought it'd be easier to merge them the other way around :( This one would probably only have one or two conflicting commits on top of mine, but I think all the commits in mine will conflict now this has changed where the affected code lives :( Oh well, I'll work through it. |
Is this 'stompest' thing not even packaged yet? |
Note this was missing a schema: https://fedora-messaging.readthedocs.io/en/latest/messages.html#schema We should add one; this should probably be done after my bz5 fixes PR is merged, because the schema would look different with and without it. |
Use the Fedora Messaging library, and migrate to stompest instead of the stomper-based moksha plugin.
Also, the app is Python3 now.