-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : System Message: ERROR/3 (<string>, line 18) Unknown directive t… #632
base: develop
Are you sure you want to change the base?
Conversation
Fixed as per recommendations and removed unnecssary code. |
HI @abompard , i was able to fix the precommit Checks on the files. But the test_index until test is failing at the assertion due to following special characters introducted in the generated html docs. But when i launch the app and view the source code from browser i dont see those special characters instead it shows the "apostrophe" correctly. Any suggestion
|
HI @abompard , fixed the issue with test_api and index page assertion looking fine now. Also precommit checks are fine. Please have a look |
Hey @novicejava1 , could you rebase the PR please? Thanks |
19f5516
to
bb2d9b6
Compare
Hi @abompard , After cloning the repo https://github.com/novicejava1/datagrepper.git. I could see the following from which i tried to rebase by picking up the first commit and did a re-push. pick 392882d Run CI on Fedora |
b7829de
to
6ad6ad7
Compare
Github still says there's some conflict on
You'll need to resolve a conflict in
|
Hi @abompard , please have a look now. I tried to resolve the conflicts |
Hi! Github is still reporting conflicts. Feel free to ask if you need help with git. |
Hi @abompard , I am unable to see any conflicts on my side. This is the message i see on my pull request. This branch has no conflicts with the base branch |
Huh, Github tells me "This branch cannot be rebased due to conflicts". I'll try to rebase it and push. |
…ype toctree. Fixes: fedora-infra#537 Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Here are a few issues that I think must be improved:
Thanks for your work on this! |
I've pushed a change with a simplisitic fix to this issue, but I think your idea of using sphinx instead of docutils has merits and should be explored, if you're still interested. |
Thanks @abompard for your inputs. I think i need to review my code further. |
Sorry previous pull request got closed accidentallty while doing sync branch.
"This pull request is a fix to update the code to utilize sphinx for building the html documents instead of docutils which currently does not support the directive type "toctree" due to which there is a system error below the "Table of Contents" section."