rework the rest of the pages #69
Conversation
added boxes for when there are no upcoming or open elections added headers on the index.html that always show
when you create an election, we set the enddate time to 23:59:59, but if you then edited that election, the time would reset to 00:00:00. this sets the time to 23:59:59 when editing anelection that already exists.
|
One issue for me:
|
|
Could we see at limiting the size of the footer? |
|
The graph showing the evolution of the votes in the result page seems to have disappeared The rest of the result page looks a little odd as well |
|
The cut-off mark seems to be gone from the result page as well (cf the red bar in https://admin.fedoraproject.org/voting/results/fesco-july-2016) |
|
The front-page looks really a little empty when there are no open or upcoming elections. I think that's all I have for now :) |
|
@pypingou the links to the elections will be on the main page as an edit link next to each election. It is also at the top of each election edit page. I changed it so you now edit the elections on the page that you also view the election as admin. rather than having a seperate admin view / edit page, you juse submit the form from there. |
The results contain the list of candidates, so no real need to show the list again at the top of the page.
|
Made the graph on the results page work again, also reworked the results page to look neater, and added back the red cut-off line. Not 100% sure what you mean by the footer, do you just want to make the min-height of the page a little bigger? the footer is itself pretty small, just on small pages the background colour of the page being set to the same colour as the footer makes it seem like the footer is large. Also, with the front page being empty, we could just get rid of the tabs altogether, and just put the list of all the completed elections on the front page too, maybe? other than that, i think this is right to go! |
|
Bugs:
Questions:
For the footer, it's like what we did for pagure, if you see a page where the content is not that big, the footer gets big. |
|
I have fixed the date picker on the edit election page. the select voting and IRC voting is now fixed too. the edit page is now a two-colomn layout as well i have also begun fixing the tests, but hit a snag going through. It seems the admin groups aren't showing up in the edit form after saving them. I tried to trouble shoot this, but couldnt figure out what was going on. I did have a play with the heatmaps, but decided to not include them, primarily becuase the colours were a little hard to parse conceptually -- does red mean "hot" as in my top pick, or does red mean "warning", i.e. a lower score. |
|
Okies, figured out the snag. It was an error i introduced. Got all the tests working now, and this one should be right for a re-review @pypingou |
| if not election: | ||
| flask.abort(404) | ||
|
|
||
| print election.admin_groups_list |
There was a problem hiding this comment.
I think this one can be dropped :)
| if not election: | ||
| flask.flash('The election, %s, does not exist.' % election_alias) | ||
| return safe_redirect_back() | ||
| elif election.status == 'Embargoed' or election.status == 'Ended': |
There was a problem hiding this comment.
maybe just elif election.status in ['Embargoed', 'Ended']?
removed debug line that was left in, and tidy up an elif statement a bit
|
@pypingou thanks again! updated the PR changing those two cleanups |
| 'admin/view_election.html', | ||
| election=election, | ||
| form=form, | ||
| submit_text='Edit election') |
|
Alright, thanks for fixing this so quickly :) Let's merge and we'll fix the rest as we see them, 👍 for me! |
|
thanks @pypingou! merging now! |
Here is the rest of the pages for elections restyled.
I have tried to reduce the number of pages a little.
Tests are going to be very broken, i want to get opinions on the new pages layout before going through and reworking all the tests.