Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer I want an comprehensive list of applications that make queries to FAS so that I can port them to the new API #9

Closed
abompard opened this issue Feb 20, 2020 · 8 comments
Assignees
Labels
spike Research needed

Comments

@abompard
Copy link
Member

A good first step would be to look into the infra Ansible repo for the fedoraDummyUserPassword variable, it means that this app is using the dummy FAS account to make queries.

Another way would be to grep all our source codes for the fedoraproject.org/accounts URL.

Once we have the list we need to look at what those apps do in their FAS queries. Whether it's read-only or not, what endpoints they are querying, etc.

AC:

  • There is a comprehensive list of apps that talk to FAS
  • For each app the list details which endpoint / which query is made
  • We mainly needs the apps that do read-only access but those who do read-write access should be flagged for later.
  • The source code / repo and points of contacts are identified
  • Code owners of those apps know that a code change will be necessary when the project is deployed, and they know that we are willing to do it or to assist them doing it.

DoD: All AC are met

@abompard
Copy link
Member Author

Can you look at that @amoloney1 please? Thanks :-)

@StephenCoady StephenCoady self-assigned this Apr 14, 2020
@abompard
Copy link
Member Author

Clément came up with a preliminary app list: https://hackmd.io/oX8Ks2FvR4CgNmhArfd2QQ

@StephenCoady
Copy link
Contributor

Thats great, thanks @abompard & @cverna. I think there might be some more so I will put them all together and then use that to make a plan with the codeowners if possible.

@bkmgit
Copy link

bkmgit commented Apr 21, 2020

Is the hackmd list the authoritative one?

@StephenCoady
Copy link
Contributor

@bkmgit no, this project's wiki has some more [1]. Its a bit rough so I will be creating individual issues shortly to list them by app/project and taking it from there. any feedback you have is welcome.

[1] https://github.com/fedora-infra/fasjson/wiki

@bkmgit
Copy link

bkmgit commented Apr 21, 2020

Would be helpful to add nuancier https://github.com/fedora-infra/nuancier

@StephenCoady
Copy link
Contributor

@bkmgit can you point me to where nuancier uses FAS currently? Maybe I missed it when I looked first.

@bkmgit
Copy link

bkmgit commented Apr 21, 2020

See https://github.com/fedora-infra/nuancier/blob/master/nuancier/__init__.py
Am working on porting this to OIDC, though if this will be available soon, then would like to use it directly instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike Research needed
Projects
No open projects
Status: Overall Done
Development

No branches or pull requests

3 participants