Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle authors from pagure messages. #67

Merged
merged 1 commit into from Mar 1, 2019
Merged

Handle authors from pagure messages. #67

merged 1 commit into from Mar 1, 2019

Conversation

cverna
Copy link
Contributor

@cverna cverna commented Feb 26, 2019

Pagure sends the authors of a commit in a list of dictionnary. This commit
supports this case by extracting the name from the dictionnary.

Fixes #60

Signed-off-by: Clement Verna cverna@tutanota.com

@cverna
Copy link
Contributor Author

cverna commented Feb 26, 2019

I am not super happy about the code but it works, also most of this logic will have to be rewritten when moving to fedora-messaging + message schema.

Pagure sends the authors of a commit in a list of dictionnary. This commit
supports this case by extracting the name from the dictionnary.

Fixes #60

Signed-off-by: Clement Verna <cverna@tutanota.com>
Copy link
Contributor

@sayanchowdhury sayanchowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sayanchowdhury sayanchowdhury merged commit bc1aca5 into fedora-infra:develop Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants