New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add tests for EC2ImageUploader #78
Open
sayanchowdhury
wants to merge
1
commit into
fedora-infra:develop
Choose a base branch
from
sayanchowdhury:feature/add-tests-in-fedimg
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# This file is part of fedimg. | ||
# Copyright (C) 2018 Red Hat, Inc. | ||
# | ||
# fedimg is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU Affero General Public License as | ||
# published by the Free Software Foundation, either version 3 of the | ||
# License, or (at your option) any later version. | ||
# | ||
# fedimg is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
# Affero General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU Affero General Public | ||
# License along with fedimg; if not, see http://www.gnu.org/licenses, | ||
# or write to the Free Software Foundation, Inc., | ||
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA | ||
# | ||
# Authors: Sayan Chowdhury <sayanchowdhury@fedoraproject.org> | ||
|
||
import unittest | ||
|
||
from fedimg.services.ec2.ec2base import EC2Base | ||
from libcloud.compute.drivers.ec2 import EC2NodeDriver | ||
|
||
|
||
class TestEC2Base(unittest.TestCase): | ||
|
||
def setUp(self): | ||
self.ec2base_obj = EC2Base() | ||
setattr(self.ec2base_obj, 'access_key', 'ABCDEFGHIJKLMNO123456789') | ||
setattr(self.ec2base_obj, 'secret_key', 'THISISASECRETKEYWITH0987') | ||
setattr(self.ec2base_obj, 'region', 'us-east-1') | ||
|
||
def test_connect(self): | ||
driver = self.ec2base_obj._connect() | ||
|
||
self.assertTrue(isinstance(driver, EC2NodeDriver)) | ||
|
||
def test_set_region(self): | ||
self.ec2base_obj.set_region('eu-east-1') | ||
self.assertEqual(self.ec2base_obj.region, 'eu-east-1') | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete this code rather than leaving it commented out. We can always find it in git's history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I added the WIP tag to this PR. I need to do a few more changes to this PR