Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss the envelope of a message in the docs. #286

Merged
merged 2 commits into from Sep 17, 2014

Conversation

ralphbean
Copy link
Contributor

Fixes #228.

@pypingou
Copy link
Member

👍

@@ -249,3 +249,20 @@ All 'fields' in a topic **should**:
- Be `singular` (Use `package`, not `packages`)
- Use existing fields as much as possible (since `complete` is already used
by other topics, use that instead of using `finished`).

**Furthermore**, the *body* of messages will contain the follow envelope:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/follow/following/ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/follow/following/

Good catch.

@lmacken
Copy link
Contributor

lmacken commented Sep 17, 2014

👍

ralphbean added a commit that referenced this pull request Sep 17, 2014
Discuss the envelope of a message in the docs.
@ralphbean ralphbean merged commit b9b3137 into develop Sep 17, 2014
@ralphbean ralphbean deleted the feature/message-body-docs branch September 17, 2014 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention msg_id on the fedmsg.com docs
3 participants