Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return only https icons where possible #89

Closed
ralphbean opened this issue May 27, 2014 · 4 comments
Closed

Return only https icons where possible #89

ralphbean opened this issue May 27, 2014 · 4 comments

Comments

@ralphbean
Copy link
Contributor

Originally filed downstream here: https://fedorahosted.org/fedora-infrastructure/ticket/4384

Right now we return avatar icons from python-fedora and lots of our own icons. Those should all be over https.

@ralphbean
Copy link
Contributor Author

Grepping the source of this repo for "http:" should help show all of the locations.

To any new contributors who try to take this on, try running the test suite before and after your change.

@ralphbean
Copy link
Contributor Author

Reported elsewhere downstream: https://fedorahosted.org/fedora-infrastructure/ticket/4388

@cydrobolt
Copy link

Hmm, is this ticket still active? Datagrepper seems to be returning images over https now, without any issues.

@ralphbean
Copy link
Contributor Author

Datagrepper seems to be returning images over https now, without any issues.

Good call. Yes, I think it's all fixed up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants