Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMN does not allow adding destinations to a rule #912

Closed
gotmax23 opened this issue May 30, 2023 · 14 comments · Fixed by #974
Closed

FMN does not allow adding destinations to a rule #912

gotmax23 opened this issue May 30, 2023 · 14 comments · Fixed by #974
Labels
deployed:prod Fix deployed to production

Comments

@gotmax23
Copy link

gotmax23 commented May 30, 2023

When I try to add a destination to a rule, I get an Unable to get the available destinations, please try again later error. This makes it impossible for me to use FMN.

Screenshot of the error message

@gotmax23
Copy link
Author

It looks like it's trying to make a request to https://fmn-api.apps.ocp.fedoraproject.org/api/v1/users/gotmax23/destinations and then getting a HTTP 500 error.

@jwflory
Copy link
Member

jwflory commented May 30, 2023

I can also reproduce this.

@mjg
Copy link

mjg commented Jun 2, 2023

Still there. It's a pitty we have that when people are trying to follow along with the release party talk on FMN.

@abompard
Copy link
Member

abompard commented Jun 2, 2023

I haven't been able to reproduce it yet, but I'm looking into it! Thanks for reporting and confirming.

@mjg
Copy link

mjg commented Jun 3, 2023

index-80312ce4.js:21     GET https://fmn-api.apps.ocp.fedoraproject.org/api/v1/users/mjg/destinations 500 (Internal Server Error)

Not sure if the console log of that request helps:
notifications.fedoraproject.org-1685791420169.log
(Happens right after new rule/add destination, where it seems to "hang" for a moment before possibly filling in the destinations menu; request fails, error pops up right after that in the log and and in the dialog as per the screenshot).

@mjg
Copy link

mjg commented Aug 24, 2023

Is there any progress or new insight on this?

It's nice to have presentations about the new greatness, but some of us are locked out from the beginning. Is there anything we can do to help track this down?

@abompard
Copy link
Member

Hey! Sorry, this issue had fallen under my radar. I'll get back to it tomorrow. It's happening every time for you?

@mjg
Copy link

mjg commented Aug 24, 2023

Hey! Sorry, this issue had fallen under my radar. I'll get back to it tomorrow. It's happening every time for you?

Yes, always. I tried every time you gave a talk on fmn and I wanted to follow along ;-)

That is, I have no rules and cannot add any just like in @gotmax23 's screenshot. Double checked matrix and e-mail settings in fas. Logged out and in etc. I have no problems with other infra like bodhi, dist-git, dashboard and the old fmn which all can query fas for my account. All of this across multiple chrome versions by now.

One thing that may or may not matter: FAS does not (or did not) allow you to use an f.p.o. e-mail address as the primary address. That primary address of mine uses "+" parts in the username part. My mjg@f.p.o. address aliases that.

@abompard
Copy link
Member

And you are correct! There's a regexp somewhere that did not validate the email address with the extension part. I'll fix it right now.

abompard added a commit to abompard/fmn that referenced this issue Aug 25, 2023
Fixes: fedora-infra#912

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard
Copy link
Member

This does not seem to be the same issue that @gotmax23 is having, though. Maxwell, could you please try again so I can check out the traceback in the logs? (I can't go digging very far in the past with our openshift logs)
Thanks.

@gotmax23
Copy link
Author

It eventually started working for me, but I forgot to update the issue.

abompard added a commit that referenced this issue Aug 28, 2023
Fixes: #912

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@mjg
Copy link

mjg commented Aug 29, 2023

Just to be sure - this change is not live in production yet, is it? (Not complaining, just cross-checking.)

@abompard
Copy link
Member

It's not, but it is on staging. Do you mind trying out https://notifications.stg.fedoraproject.org please ?

@mjg
Copy link

mjg commented Aug 30, 2023

It's not, but it is on staging. Do you mind trying out https://notifications.stg.fedoraproject.org please ?

That tries to authenticate me against id.stg.fpo (not id.fpo), which results in "Authentication failure" with my usual credentials. I guess we'll have to wait for this go live then for confirmation. Thanks in any case!

@github-actions github-actions bot added the deployed:prod Fix deployed to production label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed:prod Fix deployed to production
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants