Update contribution guide #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
odra
reviewed
May 14, 2020
|
|
||
| .. code-block:: bash | ||
|
|
||
| kubectl get all #returns all resources in the current namespace |
There was a problem hiding this comment.
I think it is worth adding a note that it won't list ingresses here
There was a problem hiding this comment.
I forgot about this, I will add command for listing the ingress. Was it kubectl get routes?
There was a problem hiding this comment.
kubectl get ingress - route is only available in openshift
|
just one comment, looks good. |
Signed-off-by: Michal Konečný <mkonecny@redhat.com>
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
Signed-off-by: Michal Konečný mkonecny@redhat.com