Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect repositories #218

Merged
merged 2 commits into from
Sep 23, 2017
Merged

Correctly detect repositories #218

merged 2 commits into from
Sep 23, 2017

Conversation

adrianreber
Copy link
Member

No description provided.

Signed-off-by: Adrian Reber <adrian@lisas.de>
The new fullfiletimelist* based umdl does not correctly create
MirrorManager repositories as described in:

 https://pagure.io/releng/issue/6977

This change scans all directories for existing 'repodata'
sub-directories and only creates MM repositories for directories with a
'repodata' sub-directory.

Fixes #216

Signed-off-by: Adrian Reber <adrian@lisas.de>
@@ -290,19 +290,6 @@ def make_repo_file_details(session, diskpath, relativeDName, D, category, target
session.commit()


def move_repository_from_development(prefix, arch, newdir):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this not called anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function has never been used. Even going back to the version 0.0.1 tag it is not used anywhere.

This step is always done manually after a release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright :)

@pypingou
Copy link
Member

One question otherwise looks fine to me :)

@adrianreber adrianreber merged commit e10f935 into fedora-infra:master Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants