Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline info lines are represented as a single line in the minutes. #687

Open
abompard opened this issue Jan 16, 2024 · 8 comments · May be fixed by #700
Open

Multiline info lines are represented as a single line in the minutes. #687

abompard opened this issue Jan 16, 2024 · 8 comments · May be fixed by #700
Assignees
Labels
good first issue Good for newcomers

Comments

@abompard
Copy link
Member

In this example, the first Info line is represented as one line, but if you look at the plain text minutes you can see that it was actually 3 lines.

@abompard abompard added the good first issue Good for newcomers label Jan 16, 2024
@sopyb
Copy link
Contributor

sopyb commented Mar 7, 2024

I will be working on this issue. I have contacted t0xic0der to ask some questions about the project since I have been stuck trying to understand the code base in some places.

@gridhead
Copy link
Member

gridhead commented Mar 8, 2024

@sopyb go ahead

@sopyb
Copy link
Contributor

sopyb commented Mar 9, 2024

I've been looking through the codebase and haven't found anything related to generating HTML files for meeting message logs or summaries. There only seems to be an option to clear the cache for specific paths through fedora messaging for when new data is added. The archive of meetings is no longer available to download online so I can't experiment and make sure that I am not missing something.

@gridhead My questions are:

  1. Can I still get the archive from anywhere?
  2. Is the code generating the summary and message logs html public (I might have missed it. Please let me know which files I should be looking in). If so in what repository?

The best fix I can think of is replacing \n with<br> on the html generation step for content that would go into <li> elements. Another option for fixing this issue is, kind of a band-aid solution where I would add the style white-space: pre-line; to items of ordered lists in the summaries.

@gridhead
Copy link
Member

@sopyb the pages for the meetings are generated on the fly with the use of templates available in the https://github.com/fedora-infra/mote/tree/main/mote/templates directory. The main.py file has the configuration for all the valid routes that the service allows for so those should lead you to the functions that generate the HTML files. The meeting logs and summaries are acquired from here https://meetbot-raw.fedoraproject.org/ so you might be able to experiment locally.

@raeeceip
Copy link

hi @gridhead is there a way to download them?

@sopyb
Copy link
Contributor

sopyb commented Mar 16, 2024

The meeting logs and summaries are acquired from here https://meetbot-raw.fedoraproject.org/ so you might be able to experiment locally.

Thanks for clarifying, @gridhead!

This is taking me way too long to wrap my head around. So, if I've got this right: the meeting logs and summaries are generated somewhere else. That means the fix I proposed earlier, where those would be modified on creation to display correctly in HTML, won't cut it.

If that's the case, then I'll move forward with adding the CSS style I mentioned before and make a pull request.

@sopyb
Copy link
Contributor

sopyb commented Mar 16, 2024

is there a way to download them?

@raeeceip Yes. All the logs and summaries are on https://meetbot-raw.fedoraproject.org

I used wget -r -P "/srv/web/meetbot" -nH -R "index.html,robots.txt" -A ".html,.txt" https://meetbot-raw.fedoraproject.org/ to download all of them but if you want to download the logs of a specific channel you could just swap https://meetbot-raw.fedoraproject.org/ for https://meetbot-raw.fedoraproject.org/fedora-meeting/

@gridhead
Copy link
Member

@sopyb could you please make changes to the README section where the developers are asked to download an archive from the Mega link and instead change it to provide the command that you mentioned in the comment #687 (comment). Your command works great and does not have us rely on a third-party service to help our developers set up their environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants