Ensure consistent event summary presentation via modal and direct access #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the statfile function in main.py to correctly generate summary URLs, including proper handling of the date in meetname. This change ensures that the URL for event summaries is correctly formed, both for direct access and when loaded in a modal. - Update statfile.html.j2 and event_summary.html.j2 templates to support redirection from '/smry' paths to canonical event pages. This ensures users experience consistent styling and functionality, regardless of access method. - Implement a redirection mechanism in main.py for '/smry' URLs to redirect to the styled event summary pages, enhancing the consistency of user experience across the platform. These changes address user feedback regarding discrepancies in content presentation between modal-loaded summaries and their directly accessed counterparts, streamlining the user interface and reinforcing intuitive navigation.
|
@raeeceip is the implementation completed yet? If not, please revert this pull request to the draft status and continue working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address user feedback regarding discrepancies in content presentation between modal-loaded summaries and their directly accessed counterparts, streamlining the user interface and reinforcing intuitive navigation.
I will note, this is still a slightly rough draft, and the /smry url loads an unstyled version of the summary page, as it does not yet redirect to the proper url
One completed, issue #687 should be resolved