Don't show disabled (locked) users

Fixes: #1210 Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
fedora-infra · Jul 21, 2023 · f8641f4 · f8641f4
1 parent ccc5dd4
commit f8641f4
Show file tree

Hide file tree

Showing 7 changed files with 2,987 additions and 2 deletions.
diff --git a/news/1210.bug b/news/1210.bug
@@ -0,0 +1 @@
+Don't show disabled (locked) users in Noggin
diff --git a/noggin/controller/root.py b/noggin/controller/root.py
@@ -86,7 +86,9 @@ def search_json(ipa):
     if username:
         users_ = [
             User(u)
-            for u in ipa.user_find(username, fasuser=True, sizelimit=10)['result']
+            for u in ipa.user_find(
+                username, fasuser=True, o_nsaccountlock=False, sizelimit=10
+            )['result']
         ]
 
         for user_ in users_:

diff --git a/noggin/utility/controllers.py b/noggin/utility/controllers.py
@@ -60,6 +60,9 @@ def group_or_404(ipa, groupname):
 
 def user_or_404(ipa, username):
     try:
-        return ipa.user_show(a_uid=username)['result']
+        user = ipa.user_show(a_uid=username)['result']
     except python_freeipa.exceptions.NotFound:
         abort(404)
+    if User(user).locked:
+        abort(404)
+    return user