Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(S) Wireframe the user detail page. This is the page that shows the details of a specific user, including the groups they belong to. #4

Closed
sfinn85 opened this issue Dec 23, 2019 · 8 comments
Assignees
Labels
S Small (~5 hours of work)
Projects

Comments

@sfinn85
Copy link

sfinn85 commented Dec 23, 2019

No description provided.

@puiterwijk puiterwijk transferred this issue from fedora-infra/freeipa-fas Jan 6, 2020
@sfinn85
Copy link
Author

sfinn85 commented Jan 7, 2020

Acceptance Criteria:

Visual wire frame of new user form
Fields ( TBC )
Working doc

DOD:
All above completed

@ryanlerch ryanlerch added this to To do in AAA Jan 7, 2020
@sfinn85 sfinn85 changed the title Wireframe the user detail page. This is the page that shows the details of a specific user, including the groups they belong to. (S) Wireframe the user detail page. This is the page that shows the details of a specific user, including the groups they belong to. Jan 7, 2020
@ryanlerch ryanlerch moved this from To do to In progress in AAA Jan 8, 2020
@ryanlerch
Copy link
Contributor

First pass at the user detail page:

userpage

@ryanlerch ryanlerch moved this from In progress to Ready for review in AAA Jan 8, 2020
@StephenCoady
Copy link
Contributor

Looks good!

@relrod relrod added the S Small (~5 hours of work) label Jan 8, 2020
@ryanlerch ryanlerch self-assigned this Jan 9, 2020
@sfinn85
Copy link
Author

sfinn85 commented Jan 14, 2020

Yep looks good to me too, again Stephen is more equipped to review. Has this changed from the current user detail page? If so, can you comment on what has changed or add a screen shot of current user detail page versus this design.

Thanks a mill

@sfinn85
Copy link
Author

sfinn85 commented Jan 15, 2020

@StephenCoady can you add a screenshot here of current page so we can review, if you have time.

@StephenCoady
Copy link
Contributor

Screenshot from 2020-01-17 14-06-30

@sfinn85
Copy link
Author

sfinn85 commented Jan 20, 2020

Thanks @StephenCoady , much better UI @ryanlerch , well done. The only dev difference I see here is the inclusion of the image. @relrod will this create more dev work?

@relrod
Copy link
Member

relrod commented Jan 20, 2020

In my POC, the image is fetched from Gravatar, using an md5 of the email that is associated with the account. So there's really no dev work to get the image working, just perhaps controversy over using gravatar, which is closed source. (There's libravatar as an open source alternative, but gravatar is much more popular, and libravatar's existence defeats the point of gravatar -- having ONE place to update your avatar.)

@sfinn85 sfinn85 closed this as completed Jan 20, 2020
@sfinn85 sfinn85 moved this from Ready for review to Done in AAA Jan 20, 2020
@sfinn85 sfinn85 moved this from Done within Sprint to Overall Done in AAA Feb 3, 2020
abompard referenced this issue in abompard/noggin Feb 20, 2020
Fixes: #72

When [CentOS CI PR #4](centosci/cico-shared-library#4)
is merged, we'll be able to revert back to just running the
`fedoraInfraTox()` macro.

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
ryanlerch pushed a commit that referenced this issue Feb 21, 2020
Fixes: #72

When [CentOS CI PR #4](centosci/cico-shared-library#4)
is merged, we'll be able to revert back to just running the
`fedoraInfraTox()` macro.

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
nphilipp added a commit to nphilipp/noggin that referenced this issue Jul 28, 2020
Signed-off-by: Nils Philippsen <nils@redhat.com>
nphilipp added a commit to nphilipp/noggin that referenced this issue Jul 29, 2020
Signed-off-by: Nils Philippsen <nils@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S Small (~5 hours of work)
Projects
No open projects
AAA
  
Overall Done
Development

No branches or pull requests

4 participants