Don't show disabled (locked) users

.github/workflows/tests.yml

@@ -32,12 +32,13 @@ jobs:
 
   unit_test:
     name: Unit tests
+    container: fedorapython/fedora-python-tox:latest
     steps:
       - uses: actions/checkout@v3
+      - name: Mark the directory as safe for git
+        run: git config --global --add safe.directory $PWD
       - name: Run tests
-        uses: fedora-python/tox-github-action@main
-        with:
-          tox_env: ${{ matrix.tox_env }}
+        run: tox -e ${{ matrix.tox_env }}
     strategy:
       matrix:
         tox_env:

Vagrantfile

@@ -26,11 +26,8 @@ Vagrant.configure(2) do |config|
   end
 
   config.vm.define "noggin" do |noggin|
-    noggin.vm.box_url = "https://download.fedoraproject.org/pub/fedora/linux/releases/34/Cloud/x86_64/images/Fedora-Cloud-Base-Vagrant-34-1.2.x86_64.vagrant-libvirt.box"
-    noggin.vm.box = "f34-cloud-libvirt"
-    # We can't use F35 yet because of https://bugzilla.redhat.com/show_bug.cgi?id=2020278
-    #noggin.vm.box_url = "https://download.fedoraproject.org/pub/fedora/linux/releases/35/Cloud/x86_64/images/Fedora-Cloud-Base-Vagrant-35-1.2.x86_64.vagrant-libvirt.box"
-    #noggin.vm.box = "f35-cloud-libvirt"
+    noggin.vm.box_url = "https://download.fedoraproject.org/pub/fedora/linux/releases/38/Cloud/x86_64/images/Fedora-Cloud-Base-Vagrant-38-1.6.x86_64.vagrant-libvirt.box"
+    noggin.vm.box = "f38-cloud-libvirt"
     noggin.vm.hostname = "noggin.noggin.test"
 
     noggin.vm.synced_folder '.', '/vagrant', disabled: true

news/1210.bug

@@ -0,0 +1 @@
+Don't show disabled (locked) users in Noggin

noggin/controller/root.py

@@ -86,7 +86,9 @@ def search_json(ipa):
     if username:
         users_ = [
             User(u)
-            for u in ipa.user_find(username, fasuser=True, sizelimit=10)['result']
+            for u in ipa.user_find(
+                username, fasuser=True, o_nsaccountlock=False, sizelimit=10
+            )['result']
         ]
 
         for user_ in users_:

noggin/utility/controllers.py

@@ -60,6 +60,9 @@ def group_or_404(ipa, groupname):
 
 def user_or_404(ipa, username):
     try:
-        return ipa.user_show(a_uid=username)['result']
+        user = ipa.user_show(a_uid=username)['result']
     except python_freeipa.exceptions.NotFound:
         abort(404)
+    if User(user).locked:
+        abort(404)
+    return user