Move all HTTP requests to be made with Python bindings for GitLab #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
|
Here's the first run-through with regular pauses when several requests have been made. Successful run after porting HTTP requests to Python bindings for GitLabI plan on getting rid of these safety nets now to see if the Python bindings for GitLab take care of the HTTP exceptions by itself - especially the one that arise due to rate limits and transient errors. |
|
So it seems that Successful run after porting HTTP requests to Python bindings for GitLabTime to take it up a notch and get rid of all EDIT - This import run took 28 minutes and 12 seconds to complete. |
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
gridhead
force-pushed
the
python-gitlab
branch
from
533b32e
to
c971a4c
Compare
|
I moved the Successful run after porting HTTP requests to Python bindings for GitLab |
|
The sharing of the same GitLab object worked and this run took 20 minutes and 21 seconds to complete. |
|
This looks great! 🎉 Nice work @gridhead. I will be able to test this out once it is merged and cut into a new release. The easiest way for me to run this would be with a new RPM package update sent to the Fedora repositories, but I could try something out with a new Pip package update too. I would prefer the RPM package update though. |
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
…ject objects Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Add exception handling code as much as possible Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
|
The code has been restored to its former glory. Current things to do
|
Zlopez
reviewed
Feb 26, 2024
gridhead
commented
Feb 27, 2024
| from pagure_exporter.main import main | ||
|
|
||
|
|
||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) |
| @@ -29,7 +29,7 @@ | |||
| from pagure_exporter.main import main | |||
|
|
|||
|
|
|||
| @pytest.mark.vcr(filter_headers=["Authorization"]) | |||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) | |||
| from pagure_exporter.work.tkts import MoveTkts | ||
|
|
||
|
|
||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) |
| standard.gpro = keepsake_gpro | ||
|
|
||
|
|
||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) |
| standard.gpro = keepsake_gpro | ||
|
|
||
|
|
||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) |
| @@ -229,7 +229,7 @@ def test_unit_iterpage_expt(caplog, srce, dest, pkey, gkey, fusr, tusr, indx, ro | |||
| standard.pagulink = "https://pagure.io/api/0" | |||
|
|
|||
|
|
|||
| @pytest.mark.vcr(filter_headers=["Authorization"]) | |||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) | |||
| @@ -285,7 +285,7 @@ def test_unit_iteriden(caplog, srce, dest, pkey, gkey, fusr, tusr, indx, stat, s | |||
| assert skip == test_iteriden[1] # noqa: S101 | |||
|
|
|||
|
|
|||
| @pytest.mark.vcr(filter_headers=["Authorization"]) | |||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) | |||
| @@ -339,7 +339,7 @@ def test_unit_iteriden_expt(caplog, srce, dest, pkey, gkey, fusr, tusr, indx, ro | |||
| standard.pagulink = "https://pagure.io/api/0" | |||
|
|
|||
|
|
|||
| @pytest.mark.vcr(filter_headers=["Authorization"]) | |||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) | |||
| @@ -492,7 +452,7 @@ def test_unit_itertkts(caplog, srce, dest, pkey, gkey, fusr, tusr, data, root, t | |||
| standard.gtlblink = "https://gitlab.com/api/v4/projects" | |||
|
|
|||
|
|
|||
| @pytest.mark.vcr(filter_headers=["Authorization"]) | |||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) | |||
| @@ -581,7 +513,7 @@ def test_unit_itercmts(caplog, srce, dest, pkey, gkey, fusr, tusr, data, root, t | |||
| standard.gtlblink = "https://gitlab.com/api/v4/projects" | |||
|
|
|||
|
|
|||
| @pytest.mark.vcr(filter_headers=["Authorization"]) | |||
| @pytest.mark.vcr(filter_headers=["Authorization", "PRIVATE-TOKEN"]) | |||
gridhead
commented
Feb 27, 2024
| session=requests.Session(), | ||
| url="https://gitlab.com", | ||
| private_token=self.code, | ||
| retry_transient_errors=True, |
There was a problem hiding this comment.
gridhead
added a commit
that referenced
this pull request
Mar 6, 2024
Move all HTTP requests to be made with Python bindings for GitLab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #60.