Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Koschei switch-input disabled for non-commiters #215

Closed
mizdebsk opened this issue Sep 2, 2015 · 3 comments · Fixed by #216
Closed

Koschei switch-input disabled for non-commiters #215

mizdebsk opened this issue Sep 2, 2015 · 3 comments · Fixed by #216
Labels

Comments

@mizdebsk
Copy link
Member

mizdebsk commented Sep 2, 2015

Koschei monitoring switch-input is disabled for non-commiters and non-admins. All packagers are allowed to toggle monitoring (and it works, tested with API and packagedb-cli), so monitoring switch should be enabled to non-owners too.

                <input type="checkbox" class="switch-input" name="koschei" id="koschei"
                  {%if package.koschei %}checked="checked"{% endif %}
                  {% if not(g.fas_user.username in admins
                            or g.fas_user.username in commiters
                            or is_admin) %} disabled="disabled"{% endif %} />
@pypingou
Copy link
Member

pypingou commented Sep 2, 2015

You mean the action is blocked in the UI while it's allowed via the API?

@mizdebsk
Copy link
Member Author

mizdebsk commented Sep 2, 2015

You mean the action is blocked in the UI while it's allowed via the API?

Yes, exactly.

@pypingou
Copy link
Member

pypingou commented Sep 2, 2015

Ok def a bug, thanks for the report and the pointer.

Marking it easyfix and I'll get to it if no-one fix it before me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants