Tweak templates to work with all specified feeds #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason I needed to do this to get it to work properly.
grdryn
force-pushed
the
migration-fixes
branch
from
1291468
to
bba992b
Compare
grdryn
commented
Nov 22, 2022
| mkdir -p ${build_dir}/${PLANET} | ||
| cp -r ${build_dir}/css-v2 ${build_dir}/${PLANET}/css-v2 | ||
| cp -r ${build_dir}/images-v2 ${build_dir}/${PLANET}/images-v2 | ||
| pluto -c ../ build ${PLANET}.ini -o ${build_dir}/${PLANET} -d ${build_dir}/${PLANET} -t planet | ||
| pluto -c ../ build ${PLANET//-/}.ini -o ${build_dir}/${PLANET} -d ${build_dir}/${PLANET} -t planet |
There was a problem hiding this comment.
It seems to be that the pluto tool doesn't like the hyphen in summer-coding, so I removed it from the ini file name and added this stripping here, and it seems to work fine now.
pluto/build/design.ini
Outdated
| # Origin: /home/fedora/nicubunu/.planet.design | ||
| [http://nicubunu.blogspot.com/feeds/posts/default?alt=rss] | ||
| name=Nicu Buculei | ||
| feed=http://nicubunu.blogspot.com/feeds/posts/default?alt=rss |
There was a problem hiding this comment.
There are a lot of non-HTTPS links in these entries. We should think about whether we should change those to HTTPS where possible.
pluto/build/edited.ini
Outdated
| ; link = http://morefedora.blogspot.com | ||
| ; feed = http://morefedora.blogspot.com/feeds/posts/default/-/justfedora/?alt=rss | ||
| ; avatar = http://www.gravatar.com/avatar/a47795df6968fe5645cd3b6b94235e86?s=80 | ||
| ; ; author = fasname |
There was a problem hiding this comment.
We should think about which fields are optional and which are required. This will have an impact on where conditionals are needed in the template files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.