AuthError not raised on 403 errors

[bowlofeggs]

I noticed today that the fedora.client.openidbaseclient.requires_login decorator does not handle 403 return codes though it looks like it's intended to. The issue is that the output variable (a requests.models.Response) does two weird things:

1. It casts to False:

ipdb> bool(output)
False

2. "anding" a Response with a bool does not return a bool:

ipdb> print (output and output.status_code)                                                                           
<Response [403]>

We probably want to do this instead:

elif hasattr(output, 'status_code') and output.status_code == 403:

[pypingou]

bool(output) is I think a documented feature, everything that is not a 20* code will return False.

The anding though it a little more odd for the least

[pypingou]

Isn't the idea of this line to protect against output being None? If so should we make it elif output is not None and output.status_code == 403 ?

[bowlofeggs]

@pypingou Yeah probably, though hasattr on None will also be False. Either way should work.

[jeremycline]

Just a heads-up, the __bool__ method is gone from Response objects in requests-3.0 and code that wants to transition smoothly shouldn't rely on it: https://github.com/kennethreitz/requests/issues/2002