Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wonky histories #141

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

nphilipp
Copy link
Member

commit 53f9f00
Author: Nils Philippsen nils@redhat.com
Date: Thu Jun 13 16:04:05 2024 +0200

Refactor creating commits in test repos

Previously, this was a couple of copy-pasted snippets of mostly boiler
plate. Move that into a convenience function, also make the spec file
template better accessible to use in individual tests.

Signed-off-by: Nils Philippsen <nils@redhat.com>

commit b5d7308
Author: Nils Philippsen nils@redhat.com
Date: Thu Jun 13 21:20:55 2024 +0200

Expose skipping various steps in the repo fixture

Signed-off-by: Nils Philippsen <nils@redhat.com>

commit 7506bd1
Author: Nils Philippsen nils@redhat.com
Date: Tue Jun 18 13:45:33 2024 +0200

Add more debugging output

Signed-off-by: Nils Philippsen <nils@redhat.com>

commit c99da5b
Author: Nils Philippsen nils@redhat.com
Date: Tue Jun 18 13:38:44 2024 +0200

Fix tripping over traverse-only commits

Previously, certain non-linear histories which involved converstion to
and/or fixing use of rpmautospec attempted to process commits that were
marked to only be traversed before and errored out because no
information was collected.

Background:
- Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2278226
- kpmcore package:
  https://src.fedoraproject.org/rpms/kpmcore/c/0ae7de895cc2b9aca799397350b5df1440c0005d?branch=epel9
- kde-partitionmanager package:
  https://src.fedoraproject.org/rpms/kde-partitionmanager/c/e8f4b3bd55c0c76b41e5943747d89e1507bf9ca3?branch=epel9

Fixes: #139

Signed-off-by: Nils Philippsen <nils@redhat.com>

Previously, this was a couple of copy-pasted snippets of mostly boiler
plate. Move that into a convenience function, also make the spec file
template better accessible to use in individual tests.

Signed-off-by: Nils Philippsen <nils@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
Previously, certain non-linear histories which involved converstion to
and/or fixing use of rpmautospec attempted to process commits that were
marked to only be traversed before and errored out because no
information was collected.

Background:
- Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2278226
- kpmcore package:
  https://src.fedoraproject.org/rpms/kpmcore/c/0ae7de895cc2b9aca799397350b5df1440c0005d?branch=epel9
- kde-partitionmanager package:
  https://src.fedoraproject.org/rpms/kde-partitionmanager/c/e8f4b3bd55c0c76b41e5943747d89e1507bf9ca3?branch=epel9

Fixes: fedora-infra#139

Signed-off-by: Nils Philippsen <nils@redhat.com>
@nphilipp nphilipp linked an issue Jun 18, 2024 that may be closed by this pull request
@nphilipp nphilipp merged commit 19ae423 into fedora-infra:main Jun 18, 2024
7 checks passed
@nphilipp nphilipp deleted the main--fix-wonky-histories branch June 18, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rhbz#2278226 - rpmautospec fails with KeyError: 'commit-id'
1 participant