Skip to content

Commit

Permalink
Merge pull request #377 from fedora-infra/optionalasserts
Browse files Browse the repository at this point in the history
Don't calculate badge stats when getting user badges
  • Loading branch information
puiterwijk committed Jan 16, 2018
2 parents 2cc7edc + 4ddba0a commit 6049939
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions tahrir/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,16 @@ def badge(request):
)


def _badge_json_generator(request, badge):
def _badge_json_generator(request, badge, withasserts=True):
if not withasserts:
return {
'id': badge.id,
'name': badge.name,
'description': badge.description,
'image': badge.image,
'tags': badge.tags,
}

try:
assertions = sorted(badge.assertions,
cmp=lambda x, y: cmp(x.issued_on, y.issued_on))
Expand Down Expand Up @@ -1143,7 +1152,8 @@ def _user_json_generator(request, user):
assertions = []
for assertion in user.assertions:
issued = {'issued': float(assertion.issued_on.strftime('%s'))}.items()
_badged = _badge_json_generator(request, assertion.badge).items()
_badged = _badge_json_generator(
request, assertion.badge, withasserts=False).items()
assertions.append(dict(issued + _badged))

return {
Expand Down

0 comments on commit 6049939

Please sign in to comment.