Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the format of error when scratch build fails #345

Closed
Zlopez opened this issue Aug 5, 2021 · 0 comments · Fixed by #367
Closed

Fix the format of error when scratch build fails #345

Zlopez opened this issue Aug 5, 2021 · 0 comments · Fixed by #367
Labels
type.bug

Comments

@Zlopez
Copy link
Contributor

Zlopez commented Aug 5, 2021

The formatting of the new error format in bugzilla is not easily readable, we need to format the traceback to look nicer and add few more empty lines. See https://bugzilla.stage.redhat.com/show_bug.cgi?id=1982962 for the current state.
@Zlopez Zlopez added the type.bug label Aug 5, 2021
@Zlopez Zlopez mentioned this issue Nov 18, 2021
Closed
Zlopez added a commit to Zlopez/the-new-hotness that referenced this issue Nov 23, 2021
@Zlopez
Unify exceptions
f3af9ca 
Create a BaseHotnessExceptions that will define the default values for
properties and methods expected by ResponseFailure class. This will help
with inconsistency when working with exceptions.

* Adds new BaseHotnessException
* Moves the message construction to BuilderException
* Adds inheritance of the BaseHotnessException to other exceptions
* Removes unecessary methods from ResponseFailure class
* Add new method for value in ResponseFailure class, this will return
  the value in exception
* Removes message construction from HotnessConsumer, to prevent crashes
  when DownloadException is returned instead of BuilderException

Fixes fedora-infra#345
Fixes fedora-infra#353

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
@Zlopez Zlopez mentioned this issue Nov 23, 2021
Merged
Zlopez added a commit that referenced this issue Nov 23, 2021
@Zlopez
Unify exceptions
c91f7df 
Create a BaseHotnessExceptions that will define the default values for
properties and methods expected by ResponseFailure class. This will help
with inconsistency when working with exceptions.

* Adds new BaseHotnessException
* Moves the message construction to BuilderException
* Adds inheritance of the BaseHotnessException to other exceptions
* Removes unecessary methods from ResponseFailure class
* Add new method for value in ResponseFailure class, this will return
  the value in exception
* Removes message construction from HotnessConsumer, to prevent crashes
  when DownloadException is returned instead of BuilderException

Fixes #345
Fixes #353

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type.bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify exceptions Zlopez/the-new-hotness
1 participant
@Zlopez