Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error message when the build didn't started yet #456

Closed
Zlopez opened this issue May 9, 2022 · 0 comments · Fixed by #457
Closed

Wrong error message when the build didn't started yet #456

Zlopez opened this issue May 9, 2022 · 0 comments · Fixed by #457

Comments

@Zlopez
Copy link
Contributor

Zlopez commented May 9, 2022

The Build started, but failure happened during post build operations should be reported only if the build id is already available. But it seems that this is not always case. See following log:

[2022-05-09 14:00:41,004 hotness.hotness_consumer INFO] Handling anitya msg '963085fd-7a66-47fe-bf24-a1f451c5d65c'
[2022-05-09 14:00:42,846 hotness.validators.mdapi INFO] Comparing upstream 5.0.0 against repo 4.1.2-2.fc30
[2022-05-09 14:00:42,847 hotness.validators.mdapi INFO] 5.0.0 is newer than 4.1.2-2.fc30
[2022-05-09 14:00:44,445 bugzilla.bug INFO] Bug 1996066 missing attribute 'bug_status' - doing implicit refresh(). This will be slow, if you want to avoid this, properly use query/getbug include_fields, and set bugzilla.bug_autorefresh = False to force failure.
[2022-05-09 14:00:44,701 hotness.notifiers.bugzilla INFO] Created bug: #1996066 NEW        - m@rtinbriza.cz - mediawriter-5.0.0 is available
[2022-05-09 14:00:44,701 hotness.notifiers.bugzilla INFO] Filled a new bug '[https://bugzilla.stage.redhat.com/show_bug.cgi?id=1996066' ](https://bugzilla.stage.redhat.com/show_bug.cgi?id=1996066%27)
[2022-05-09 14:00:44,702 hotness.notifiers.fedora_messaging INFO] publishing topic 'hotness.update.bug.file'
[2022-05-09 14:00:44,866 hotness.builders.koji INFO] Cloning '[https://src.stg.fedoraproject.org/rpms/mediawriter.git' ](https://src.stg.fedoraproject.org/rpms/mediawriter.git') to '/var/tmp/thn-vojyvz6e'
Using mediawriter.spec
/   0.0 B Elapsed Time: 0:00:00
-   0.0 B Elapsed Time: 0:00:00
[2022-05-09 14:00:47,532 hotness.use_cases.package_scratch_build_use_case ERROR] Package scratch build use case failure
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/hotness/builders/koji.py", line 168, in build
    cmd_output = sp.check_output(
  File "/usr/lib64/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib64/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['rpmbuild', '-D', '_sourcedir .', '-D', '_topdir .', '-bs', '/var/tmp/thn-vojyvz6e/mediawriter.spec']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/hotness/use_cases/package_scratch_build_use_case.py", line 56, in build
    result = self.builder.build(request.package, request.opts)
  File "/usr/local/lib/python3.9/site-packages/hotness/builders/koji.py", line 188, in build
    raise BuilderException(
hotness.exceptions.builder_exception.BuilderException: Build started, but failure happened during post build operations:
Command '['rpmbuild', '-D', '_sourcedir .', '-D', '_topdir .', '-bs', '/var/tmp/thn-vojyvz6e/mediawriter.spec']' returned non-zero exit status 1.

StdOut:
error: Bad source: ./MediaWriter-5.0.0.tar.gz: No such file or directory

I should look what is happening there

@Zlopez Zlopez changed the title Build started, but failure happened during post build operations before rpmbuild started Wrong error message when the build didn't started yet May 9, 2022
Zlopez added a commit to Zlopez/the-new-hotness that referenced this issue May 9, 2022
Hotness didn't checked the build_id variable for value when creating error
message and erroneously reported that the build already started.

This commit is adding the check for zero together with new test.

Fixes fedora-infra#456

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
Zlopez added a commit that referenced this issue May 9, 2022
Hotness didn't checked the build_id variable for value when creating error
message and erroneously reported that the build already started.

This commit is adding the check for zero together with new test.

Fixes #456

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant