Modulemd.ModuleIndexMerger.test_merger_with_real_world_data into C #412
Conversation
madhavmehndiratta
changed the title
There was a problem hiding this comment.
Great start! Welcome to Modularity :D
You have created a test/function. Now you need this test to run. All execution starts from the main. Hence you need to define your tests there. This will make sure your tests are running ad are correct.
Please look at https://github.com/fedora-modularity/libmodulemd/blob/master/modulemd/tests/test-modulemd-merger.c#L249 to see how other tests of this file have been added.
| @@ -273,3 +273,31 @@ main (int argc, char *argv[]) | |||
|
|
|||
| return g_test_run (); | |||
| } | |||
|
|
|||
| test_merger_with_real_world_data (ModuleStreamFixture *fixture, | |||
There was a problem hiding this comment.
Every function in C needs a return type unlike in Python. Here the return type would be static void. This would throw you a compilation error when running ninja
There was a problem hiding this comment.
I've updated the file again and fixed some errors.
There was a problem hiding this comment.
Please push your changes to this PR so that I can see them.
modulemd/modulemd-util.c
Outdated
| @@ -360,7 +360,7 @@ modulemd_validate_nevra (const gchar *nevra) | |||
| { | |||
| break; | |||
| } | |||
| else if (*i == '-') | |||
| if (*i == '-') | |||
There was a problem hiding this comment.
Why this? Put it back to original please.
There was a problem hiding this comment.
The code formatter that we run during ninja test recently started to drop unneeded else statements. It's unrelated to this change. I've pushed this to the current master branch so it doesn't keep showing up.
There was a problem hiding this comment.
Tests are still failing because you didn't run ninja test before pushing the latest version. The g_test_add_func () line is more than 79 characters long, which means that the code-reformatting tool will rewrite it during ninja test.
Please run ninja test and then amend the patch with the fixes.
|
@Mr-M1M3 Please rebase and run |
Modulemd.ModuleIndexMerger.test_merger_with_real_world_data into C
|
I ran ninja test before commiting the changes, still the error exists |
Modulemd.ModuleIndexMerger.test_merger_with_real_world_data into C Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Copied python test to C for https://github.com/fedora-modularity/libmodulemd/blob/master/modulemd/tests/ModulemdTests/merger.py#L238-254