Copying Modulemd.ModuleStream.community into C #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgallagher
requested changes
Jan 7, 2020
There was a problem hiding this comment.
libmodulemd:ERROR:../modulemd/tests/test-modulemd-modulestream.c:1993:module_stream_v2_test_community: assertion failed (community == MMD_TEST_DOC_TEXT): (NULL == "http://example.com")
The error is right there in the paste.
The problem is that you need to use the correct objects when getting and setting values. MMD_TEST_DOC_PROP is not the right property for setting and retrieving the 'community' property.
OrionStar25
reviewed
Jan 8, 2020
| @@ -2311,6 +2411,20 @@ main (int argc, char *argv[]) | |||
| module_stream_v2_test_rpm_map, | |||
| NULL); | |||
|
|
|||
| g_test_add ("/modulemd/v2/modulestream/v1/community", | |||
There was a problem hiding this comment.
I'd suggest you to use g_test_add_func() like its done below because we have to change it into that anyway.
OrionStar25
reviewed
Jan 8, 2020
| NULL, | ||
| module_stream_v2_test_community, | ||
| NULL); | ||
|
|
||
| g_test_add_func ("/modulemd/v2/modulestream/v2/unicode/description", |
There was a problem hiding this comment.
Please replace g_test_add() with this.
|
Copying python tests to C Fixed some errors Added v1 module Fixed some errors
sgallagher
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting error while using ninja test, here is the error https://paste.centos.org/view/83ee0ace