Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modulemd-stream v3 #487

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

mmathesius
Copy link
Collaborator

@mmathesius mmathesius commented Oct 15, 2020

Initial implementation of new ModuleStreamV3 object, parsing/emitting of modulemd-stream v3 documents, and a basic parse/dump test.

@mmathesius mmathesius changed the title modulemd v3 development Add modulemd-stream v3 Oct 19, 2020
@mmathesius
Copy link
Collaborator Author

CC: @mcurlej

modulemd/modulemd-module-stream.c Outdated Show resolved Hide resolved
modulemd/modulemd-module-stream.c Outdated Show resolved Hide resolved
modulemd/tests/ModulemdTests/modulestream.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sgallagher sgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmathesius
Copy link
Collaborator Author

I just added one small improvement for context validation. Assuming you're good with it, can we go ahead and squash these commits and merge into the devel branch?

@sgallagher
Copy link
Collaborator

I just added one small improvement for context validation. Assuming you're good with it, can we go ahead and squash these commits and merge into the devel branch?

Go ahead.

Create object type with getters/setters, YAML parser/emitter, and unit tests.

Signed-off-by: Merlin Mathesius <mmathesi@redhat.com>
@mmathesius
Copy link
Collaborator Author

I just added one small improvement for context validation. Assuming you're good with it, can we go ahead and squash these commits and merge into the devel branch?

Go ahead.

Thanks, @sgallagher. Squashed and rebased with the OpenMandriva workaround. I'll merge when I confirm CI passes.

@mmathesius mmathesius merged commit 2602c8b into fedora-modularity:mmdv3-devel Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants