Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the JS graph show Python 2 dropping status #491

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

encukou
Copy link
Member

@encukou encukou commented Dec 6, 2018

Also:

  • Remove Group graphs entirely
  • Avoid the DB in the web app
  • Require networkx

And, this makes the graph CPU-hungry again.

Also:
- Remove Group graphs entirely
- Avoid the DB in the web app
- Require networkx
@hroncok
Copy link
Member

hroncok commented Dec 6, 2018

_

Not sure how do I read that graph yet, but it is indeed CPU hungry :D

@hroncok
Copy link
Member

hroncok commented Dec 6, 2018

Shouldn't the text above the graph be updated?

@encukou
Copy link
Member Author

encukou commented Dec 6, 2018

Ah, good catch! I knew I forgot something.

Darker colors mean more dependencies.
Here is a graph showing dependency relationships for
packages in Fedora Rawhide that need Python 2 in some way.
Brighter colors roughly mean the package can be removed sooner.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I guess I don't get that part. I see the same colors as in portingdb. How is their brightness showing when they can be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones that can't be removed easily are dark (and they're in the center).
Granted, it's not very obvious – and perhaps not even helpful. Should this just use the same colors as everywhere else?
Here's the graph with this shading turned off:

btightgraph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see it on the green ones. And only now when you showed me. Better ask another person as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the "hard to remove" ones are mostly green (and gray).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we bikeshedding at this point?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Keep the colors.

@encukou encukou merged commit 1fdc7c6 into fedora-python:master Dec 10, 2018
@encukou encukou deleted the jsgraph-dropping branch December 10, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants