Allow lazy evalution of some of the Extension's attributes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
changed the title
hroncok
force-pushed
the
lazy_extension
branch
2 times, most recently
from
1349e87
to
9c78477
Compare
setup.py
Outdated
| def __init__(self, *args, **kwargs): | ||
| self._pkg = kwargs['pkg'] | ||
| del kwargs['pkg'] | ||
| if 'extra_libraries' in kwargs: |
There was a problem hiding this comment.
If it isn't really necessary to delete 'extra_libraries' from kwargs, you can use just self._extra_libraries = kwargs.get('extra_libraries', []) instead of condition.
There was a problem hiding this comment.
The later called Extension.__init__ warns for any unrecognized kwarg.
There was a problem hiding this comment.
Ok, I see that you are using kwargs on line 29 so deleting extra_libraries is probably necessary and you can ignore my previous comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #12