Skip to content

Commit

Permalink
Drop the limited support of tox 3.13 and 3.14 (due to Fedora 31 EOL)
Browse files Browse the repository at this point in the history
  • Loading branch information
hroncok committed Nov 20, 2020
1 parent ffc3a58 commit 3070d20
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 20 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
tox_env:
# This information is repeated in tox.ini
# (see https://github.com/fedora-python/tox-github-action/issues/8)
- py36-tox313
- py37-tox313
- py36-tox315
- py37-tox315
- py38-tox315
- py39-tox315

Expand Down
6 changes: 1 addition & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ def long_description():
packages=find_packages("src"),
entry_points={"tox": ["current-env = tox_current_env.hooks"]},
install_requires=[
# We support tox 3.13 only to support Fedora 31.
# Fedora's tox 3.13 is patched to support Python 3.8 and 3.9,
# but the one downloaded from PyPI isn't and it doesn't work properly.
"tox>=3.15; python_version >= '3.8'",
"tox>=3.13; python_version < '3.8'",
"tox>=3.15",
"importlib_metadata; python_version < '3.8'"
],
python_requires=">=3.6",
Expand Down
11 changes: 0 additions & 11 deletions tests/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
import configparser
import contextlib

from packaging import version

import pytest


Expand Down Expand Up @@ -97,10 +95,6 @@ def is_available(python):
return True


TOX_VERSION = version.parse(tox("--version").stdout.split(" ")[0])
TOX313 = TOX_VERSION < version.parse("3.14")


needs_py36789 = pytest.mark.skipif(
not all((is_available(f"python3.{x}") for x in range(6, 10))),
reason="This test needs python3.6, 3.7, 3.8 and 3.9 available in $PATH",
Expand Down Expand Up @@ -398,11 +392,6 @@ def test_regular_run():
assert "/.tox/py39 is the exec_prefix" in lines[3]
assert "congratulations" in result.stdout
for y in 6, 7, 8, 9:
if TOX313 and y > 8:
# there is a bug in tox < 3.14,
# it creates venv with /usr/bin/python3 if the version is unknown
# See https://src.fedoraproject.org/rpms/python-tox/pull-request/15
continue
for pkg in "py", "six", "test":
sitelib = DOT_TOX / f"py3{y}/lib/python3.{y}/site-packages"
assert sitelib.is_dir()
Expand Down
3 changes: 1 addition & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@

# This information is repeated in .github/workflows/main.yaml
# (see https://github.com/fedora-python/tox-github-action/issues/8)
envlist = {py36,py37,py38,py39}-tox{release,master},{py36,py37}-tox313,{py38,py39}-tox315
envlist = {py36,py37,py38,py39}-tox{release,master,tox315}

[testenv]
deps=
pytest
pytest-xdist
packaging
tox313: tox >=3.13,<3.14
tox315: tox >=3.15,<3.16
toxrelease: tox
toxmaster: git+https://github.com/tox-dev/tox.git@master
Expand Down

0 comments on commit 3070d20

Please sign in to comment.