Injecting whitelist_externals break tox.ini files using newer allowlist_externals

[ssbarnea]

The line at

tox-current-env/src/tox_current_env/hooks.py

Line 75 in 60d4e23

config.envconfigs[testenv].whitelist_externals = "*"

effectively breaks any tox.ini file that used the newer allowlist_externals by causing something like:

...
  File "/usr/lib/python3.9/site-packages/tox/venv.py", line 217, in _check_external_allowed_and_warn
    if not self.is_allowed_external(path):
  File "/usr/lib/python3.9/site-packages/tox/venv.py", line 237, in is_allowed_external
    raise tox.exception.ConfigError(
tox.exception.ConfigError: ConfigError: Either whitelist_externals or allowlist_externals might be specified, not both

[hroncok]

Thanks for the report. I guess we need to check what value to set -- note that we support tox 3.15 but can migrate to 3.18 and prefer allowlist_externals.

tox-current-env/setup.py

Line 22 in 7b2047d

"tox>=3.15",

[hroncok]

@ssbarnea Do you wish to attempt to tackle this?

[ssbarnea]

I can try, I already had to do something like this for another plugin. In fact we can even neuter the feature and avoid altering the config to avoid it.

[ssbarnea]

@hroncok In fact bumping tox version is not enough because newer versions of tox did not remove the support for old whitelist_externals, only added a warning. LOTS of project did not act on these for various reasons.

The only workaround for this is to detect which one is used in current file. Have a look at another plugin where I had to do something similar: https://github.com/tox-dev/tox-ansible/blob/a26989e4144933d323f8bf443326b73bf710c3c6/src/tox_ansible/tox_helper.py#L144

In general I am ok to bump deps to avoid adding extra complexity but that one is more difficult.