Fix users for SELinux userspace 3.4 #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest yet to be released userspace version 3.4 added new validation and discovered several issues in current implementation. This patch tries to address them: - move guest and xguest module from contrib to roles - refpolicy did this change long time ago - roles guest_r and xguest_r need to be defined in kernel.te - gen_user() is supposed to be in policy/users, not in modules - drop role multiple definitions from userdom_base_user_template as it's and is supposed to be defined in kernel.te
|
LGTM, I will merge it soon. Thank you for your effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest yet to be released userspace version 3.4 added new validation and
discovered several issues in current implementation. This patch tries to
address them:
move guest and xguest module from contrib to roles - refpolicy did
this change long time ago
roles guest_r and xguest_r need to be defined in kernel.te
gen_user() is supposed to be in policy/users, not in modules
drop role multiple definitions from userdom_base_user_template as it's
and is supposed to be defined in kernel.te