Reuse tmpfs_t also for the ramfs filesystem #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd-creds apparently runs in a chroot where /dev/shm is backed by ramfs instead of the usual tmpfs. ramfs currently uses a separate type (ramfs_t), but both ramfs and tmpfs can in fact be used for the same things interchangeably and since commit a769746 ("filesystem: add fs_use_trans for ramfs"), they also use the same superblock labeling scheme, and thus it would be natural to use a single type for both. This commit implements this idea, dropping the ramfs_t type and instead using the tmpfs_t type in its place (with ramfs_t being an alias for tmpfs_t for backwards compatibility). The ramfs-specific interfaces are deprecated and references to them are removed from the policy (as all of them seem to be related to rhgb or readahead, which are not currently shipped in Fedora and will likely be completely removed from the policy in the future). I ran my work laptop with a policy including this patch for several days and noted no regressions or denials. Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
|
Merging, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-creds apparently runs in a chroot where /dev/shm is backed by ramfs instead of the usual tmpfs. ramfs currently uses a separate type (ramfs_t), but both ramfs and tmpfs can in fact be used for the same things interchangeably and since commit a769746 ("filesystem: add fs_use_trans for ramfs"), they also use the same superblock labeling scheme, and thus it would be natural to use a single type for both.
This commit implements this idea, dropping the ramfs_t type and instead using the tmpfs_t type in its place (with ramfs_t being an alias for tmpfs_t for backwards compatibility).
The ramfs-specific interfaces are deprecated and references to them are removed from the policy (as all of them seem to be related to rhgb or readahead, which are not currently shipped in Fedora and will likely be completely removed from the policy in the future).
I ran my work laptop with a policy including this patch for several days and noted no regressions or denials.
This is an alternative to #1295.