Allow init read all non-security socket files #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systemd uses the LoadCredential option to pass a credential to the unit.
Credentials here are small objects that may be passed to unit processes,
typically cryptographic keys or certificates, user account information
or identity information from host to services.
The credential files/IPC sockets must be accessible to the service manager,
but don't have to be directly accessible to the unit's processes: the
credential data is read and copied into separate, read-only copies for
the unit that are accessible to appropriately privileged processes.
Consequently, when LoadCredential is set to point to a socket file,
systemd needs the read permission for the sock_file security class:
LoadCredential=id:/run/wg-credentials.socket
Systemd in its read_full_file_full() function checks exit code of
xfopenat() and in case of -ENXIO connects to the AF_UNIX socket.
The files_read_non_security_sock_files() interface was added.
Addresses the following AVC denial:
type=AVC msg=audit(1672210323.355:1362): avc: denied { read } for pid=4490 comm="(sd-mkdcreds)" name="wg-credentials.socket" dev="tmpfs" ino=1033 scontext=system_u:system_r:init_t:s0 tcontext=system_u:object_r:var_run_t:s0 tclass=sock_file permissive=0
zpytela
force-pushed
the
sd-creds-sockets
branch
from
68d2613
to
6f9608f
Compare
|
Hi, I installed the rpm from the build and got one step further, but there is now a new block for connect |
|
@umglurf, is this a custom service, not in Fedora? |
Hi, that is correct, it's a service I've written, but I think this would be the same issue with services in Fedora. I can create a small demo service if that would be helpful? |
|
That'd be nice. If a similar AVC appears, the following module should help: |
I've attached a simple credential server that just always returns
That worked. |
|
@zpytela any update on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permission is required when LoadCredential is set to point to a socket file for providing credentials to a service:
LoadCredential=id:/run/wg-credentials.socket
Systemd in its read_full_file_full() function checks exit code of xfopenat() and in case of -ENXIO connects to the AF_UNIX socket.
The files_read_non_security_sock_files() interface was added.
Addresses the following AVC denial:
type=AVC msg=audit(1672210323.355:1362): avc: denied { read } for pid=4490 comm="(sd-mkdcreds)" name="wg-credentials.socket" dev="tmpfs" ino=1033 scontext=system_u:system_r:init_t:s0 tcontext=system_u:object_r:var_run_t:s0 tclass=sock_file permissive=0