lircd: Fix new drop-root-permissions denials (v2) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2015
Closed
| @@ -40,6 +40,8 @@ dev_filetrans(lircd_t, lircd_var_run_t, sock_file) | |||
|
|
|||
| kernel_request_load_module(lircd_t) | |||
|
|
|||
| auth_read_passwd(lircd_t) | |||
There was a problem hiding this comment.
Changes are OK. We just need to follow StyleGuide. See
https://github.com/TresysTechnology/refpolicy/wiki/StyleGuide
and Local policy rules section. It means you need to call
auth_read_passwd(lircd_t)
after
term_use_unallocated_ttys(lircd_t)
Thank you.
mgrepl
added a commit
that referenced
this pull request
Nov 10, 2015
lircd: Fix new drop-root-permissions denials (v2)
tmcneal
pushed a commit
to tmcneal/lirc
that referenced
this pull request
Sep 9, 2017
Lets make an upstream policy patch instead: fedora-selinux/selinux-policy#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New try: Add some new permission needed for new code dropping root privileges using setuid()