Label /dev/dma_heap/* char devices with dma_device_t #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4604ae8 in favor of less comples approach.
This reverts commit 77d425c in favor of less complex approach.
This reverts commit a091bcd in favor of less complex approach.
In the /dev/dma_heap directory, character devices are created to allow userspace to allocate dma buffers that can be shared between drivers. The change is backed by a file transition for the "system" file; note the /dev/dma_heap directory keeps the default device_t type so the transition will apply for a "system" file anywhere in /dev. A new dma_device_t type was added. Resolves: rhbz#1970744
|
Taking the discussion in #763 and the current Fedora state into account, I decided to revert the current solution in favor of the least complex one, and not label /dev/dma_heap with a private, unique type. I am afraid though we will need to get back to it later unless we decide to drop all transitions as also discussed. There already is a request for Note to myself: In that case, a dozen of interfaces like dev_manage_all_dev_nodes will need to be updated. |
zpytela
changed the title
|
Testing the new build, I haven't run into any issue, so undrafting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.