Drop cockpit module and stop ignoring standalone interface files #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an alternative to #853 |
|
Again, the build-rpm fail is expected since cockpit needs to be removed from modules-targeted-contrib.conf (but setting it to "OFF" is not necessary with this approach). |
Closed
|
Rebased |
|
Any update on this? |
Now it's time to move it forward. |
|
Rebased. |
The module is now maintained and shipped as part of cockpit. https://github.com/cockpit-project/cockpit/tree/main/selinux Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
Interface files without corresponding .te where ignored, unless the module name was specified in modules.conf. Standalone interface files are useful for backwards compatibility in case a policy module removed from this repository. Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
|
rebased |
|
Merged, thank you for the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.