Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Several issues in Silverblue open/save dialogs since 20220314 or so #245

Closed
AdamWill opened this issue Mar 17, 2022 · 9 comments
Closed

Comments

@AdamWill
Copy link

Describe the bug
Since Fedora-36-20220314.n.0 or Fedora-36-20220315.n.0, the Open and Save dialogs on Silverblue have changed, and there are some issues openQA ran into. I recall that these dialogs are specially implemented for Silverblue so I'm filing this as a Silverblue-specific issue. The problems:

  1. When opening a folder with a single file of the expected type, that file used to show up highlighted in blue, but now it shows up with a grey background sort of outlined in blue:
    greyblue
  2. The fonts used on various elements are different. As you can see in that picture, the "Cancel" and "Open" button labels are in boldface; they weren't before, and still aren't on Workstation. The "Name", "Size", "Type" and "Modified" column headers also look a bit odd; they seem smaller, and there are no separators between them. Previously in Silverblue, and still in Workstation, the headers were larger and there were separators between them.
  3. When you hit "Save As...", the name portion of the default filename is not pre-selected, as it was before and still is in Workstation. So if you just hit "Save As..." and type "foo" and hit enter, you'll wind up saving the file as 'fooUntitled Document.txt' or 'foopreviousname.pdf' or something like that, rather than 'foo.txt' or 'foo.pdf' as you would previously and still do on Workstation.

To Reproduce
Please describe the steps needed to reproduce the bug:

  1. Install a recent Fedora 36 Silverblue image, run an app like gnome-text-editor or evince, and try opening and saving files.
@AdamWill
Copy link
Author

I can't tell if this is the case with Rawhide because Silverblue on Rawhide is still running into https://bugzilla.redhat.com/show_bug.cgi?id=2059776 .

@tpopela
Copy link
Contributor

tpopela commented Mar 17, 2022

Yes, I see it here, but I thought that it's expected.

I recall that these dialogs are specially implemented for Silverblue

That's not true. If I'm not mistaken, then these dialogs are provided by the Flatpak portals as GNOME Text Editor or Evince are shipped as Flatpaks on Silverblue (at this moment these are Flatpaks from Fedora 35 - could that play a role). Honestly with Kalev on sabbatical we might actually miss some update in the Fedora 35 Flatpak runtime, but I don't whether it could cause this. @matthiasclasen any idea?

@AdamWill
Copy link
Author

oh, yeah, that's what I was remembering. Still, it's kinda effectively quite specific to Silverblue, as it's the only thing that ships apps pre-installed as flatpaks.

@AdamWill
Copy link
Author

AdamWill commented Mar 17, 2022

Interestingly, Silverblue's eog's "Set Background" dialog has the same bolded button labels:
eogbold
we have a previous version of that screenshot with non-bold button labels (the shade of grey used as the background of the dialog is slightly different too). Current non-flatpak eog shows a bar in the main window rather than a dialog, so can't make a direct comparison to current.

@AdamWill
Copy link
Author

Looks like indeed Silverblue eog had the 'non-boldface' labels in that dialog in Fedora-36-20220314.n.0, but got the boldface labels in Fedora-36-20220315.n.0.

@felipeborges
Copy link

felipeborges commented Mar 18, 2022

These are Portal dialogs provided by https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome

They are GTK4, that's what makes them different from Evince and Eog (gtk3).

@tpopela
Copy link
Contributor

tpopela commented Mar 18, 2022

And there's this build of it https://koji.fedoraproject.org/koji/buildinfo?buildID=1930785 (update to 42.x release) from March 8 that might went into stable few days ago - https://bodhi.fedoraproject.org/updates/FEDORA-2022-21d81706cd - to that might be it..

@AdamWill
Copy link
Author

Thanks, yeah, that does seem to more or less line up. I guess I'll file an issue there.

@AdamWill
Copy link
Author

tcooper pushed a commit to tcooper/os-autoinst-distri-rocky that referenced this issue May 18, 2022
The open/save dialogs for Flatpak apps in current F36 (and
probably Rawhide, but can't tell due to another bug) look a bit
odd: fedora-silverblue/issue-tracker#245
This adds variant needles to handle various differences there.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants