This repository has been archived by the owner on May 26, 2023. It is now read-only.
Added Dark Mode CSS #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It look fine to me, but I do not know who is in charge of the website. @sanjabonic , you know who deal with that ? |
ghost
merged commit 
|
Awesome PR - thanks for submitting that! |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was just reading hacker news and saw this rather cool new feature that is being built into browsers. In this case the support for dark mode for browsers that request it.
I was hoping to use this as one of my hacktoberfest submissions this year, so please let me know if there are things so i can fix it.
EDIT: FYI you won't see it unless your browser is asking for dark mode sites. Otherwise you would normally get the bright white website. To enable dark mode requests on Firefox just apply the following setting.
url > about:config > accept the risk > right click > new > integer
key is ui.systemUsesDarkTheme
value is 1
EDIT2: FYI this isn't some random CSS that is only supported on Firefox. It has support in Chrome, Safari etc.. https://caniuse.com/#search=prefers-color-scheme
Kind regards,
Krish