Add 4 dnifti #30
Merged
Add 4 dnifti #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some boilerplate code and allows module reloading in developer mode. Also cleanup some trailing whitespace
This works for the SIRP dataset from this page https://nifti.nimh.nih.gov/nifti-1/data Other files may or may not work as expected.
|
@pieper looks good, thank you! I will add you as a contributor so you can merge if it is ready. Can you also update the hash in Slicer https://github.com/Slicer/Slicer/blob/master/SuperBuild.cmake#L228 after it's merged? |
Note that we have no test data to confirm that the units code is correct. This code appears to work well with the sample data from [1]. [1] https://nifti.nimh.nih.gov/nifti-1/data
|
committed to Slicer in r27040 |
slicerbot
pushed a commit
to Slicer/SlicerGitSVNArchive
that referenced
this pull request
Mar 11, 2018
fedorov/MultiVolumeImporter#30 From: Steve Pieper <pieper@isomics.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@27040 3bd1e089-480b-0410-8dfb-8563597acbee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fedorov this work at least for the one data file.