Skip to content

Commit

Permalink
[internal-branch.go1.17-vendor] http2: remove PingTimeout from TestTr…
Browse files Browse the repository at this point in the history
…ansportPingWhenReading

Use the default PingTimeout since it has no bearing on the test. A small
value can cause a failure on slower machines. Rely on the deadline to
determine a sufficient amount of time to complete.

Updates golang/go#49077

Change-Id: I9389777fa00ed5193f1fc7ae04d2e2134114c675
Reviewed-on: https://go-review.googlesource.com/c/net/+/352970
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/net/+/357682
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
  • Loading branch information
fraenkel authored and dmitshur committed Oct 29, 2021
1 parent 7e8f03d commit a4693d5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion transport_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3437,7 +3437,6 @@ func TestTransportPingWhenReading(t *testing.T) {
func testTransportPingWhenReading(t *testing.T, readIdleTimeout, deadline time.Duration, expectedPingCount int) {
var pingCount int
ct := newClientTester(t)
ct.tr.PingTimeout = 10 * time.Millisecond
ct.tr.ReadIdleTimeout = readIdleTimeout

ctx, cancel := context.WithTimeout(context.Background(), deadline)
Expand Down

0 comments on commit a4693d5

Please sign in to comment.