Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to rocky linux #4092

Merged
merged 2 commits into from
Jun 7, 2024
Merged

switch to rocky linux #4092

merged 2 commits into from
Jun 7, 2024

Conversation

boozallendanny
Copy link
Contributor

Description:
High level description of what the PR addresses should be put here. Should be detailed enough to communicate to a PO what this PR addresses without diving into the technical nuances

Technical details:
The technical details for the knowledge of other developers. Any detailed caveats or specific deployment steps should be outlined here.

Requirements for PR merge:

  1. Unit & integration tests updated
  2. API documentation updated
  3. Necessary PR reviewers:
    • Backend
    • Frontend
    • Operations
    • Domain Expert
  4. Matview impact assessment completed
  5. Frontend impact assessment completed
  6. Data validation completed
  7. Appropriate Operations ticket(s) created
  8. Jira Ticket DEV-123:
    • Link to this Pull-Request
    • Performance evaluation of affected (API | Script | Download)
    • Before / After data comparison

Area for explaining above N/A when needed:

boozallendanny
boozallendanny commented May 21, 2024
View reviewed changes
Dockerfile
@@ -37,6 +43,8 @@ WORKDIR /dockermount
COPY requirements/ /dockermount/requirements/
RUN python3 -m pip install -r requirements/requirements.txt

RUN python3 -m pip install -r requirements/requirements-server.txt ansible==2.9.15 awscli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the Dockerfile-Server ? We can install both files in one dockerfile

@boozallendanny boozallendanny merged commit 2211ed7 into dev-10645-python-upgrade-3.10 Jun 7, 2024
1 check failed
@boozallendanny boozallendanny deleted the mod/dockerfile-python310 branch June 7, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collinwr collinwr collinwr approved these changes

@ayubshahab ayubshahab ayubshahab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boozallendanny @collinwr @ayubshahab