New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lineup #29
Commits on Feb 15, 2014
Commits on Feb 16, 2014
-
-
-
handmade call graph to guide refactoring
See discussion in github issues. #19
-
-
-
-
-
flipping through history changes lineup
I rewrote the logic here to avoid anything more complicated that pushing or poping pages. I struggled to find algorithm that was symetric between old and new pages. Both loops now preserve the prefix (pages that are matching) which I moved out of logic and into a variable. This was expressed as an 'unless' statement but coffeescript messed up the application of demorgan's law.
-
-
-
we don't patch in missing array operations any more
This was only used once, very early. I've hunted for the spot but can't find it. The error message should be clear to anyone who knows that we've removed this global modification.
-
-
-
-
-
cleaner handling of newPage from future and template
This is the first operation that depends on the lineup being correct. It makes sense that it should be first. It struggled (and still does some) to pull all the pieces together.
-
-
Commits on Apr 13, 2014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.