Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add overlay maps #24

Merged
merged 2 commits into from
Feb 12, 2019
Merged

add overlay maps #24

merged 2 commits into from
Feb 12, 2019

Conversation

WardCunningham
Copy link
Member

Leaflet is happy to overlay images so we add that capability with specialized markup.

image

Here we overlay the George Fox University campus map within the city of Newberg, Oregon and then locate the Engineering Maker Hub on that map with a clickable marker.

@WardCunningham
Copy link
Member Author

Not sure when or how, but the fixing of the mouse-grabbing of the map plugin was a life-saver. The interaction is not perfect but workable now - although mobile is tricky - ideally we want to be able to fix a map so it is not able to scroll and enable a full screen mode (or link to a new tab) where we can scroll in the map.

@fortyfoxes: Please explain what behavior is different with the map plugin. It was not my intention to change anything other than adding the overlay. Some Leaflet expertise would be helpful.

@paul90
Copy link
Member

paul90 commented Feb 11, 2019

Looks as if David is referring to a behaviour that was resolved in 5f04e66 (June 2018). If I remember correctly this was made possible thanks to upgrading to a newer version of Leaflet.

@WardCunningham
Copy link
Member Author

For the decimal notation the point example has a space after the comma. Having a space after the coma is not allowed by the current OVERLAY. I think it would be an idea to allow a space. What do you think?

I agree. With such a long command it is still a good idea to use space sparingly. I was feeling that I was overly generous with the other regular expressions.

@paul90 paul90 merged commit 53fa1c1 into master Feb 12, 2019
@paul90 paul90 deleted the ward/overlay branch February 12, 2019 15:08
@paul90
Copy link
Member

paul90 commented Feb 12, 2019

Published as + wiki-plugin-map@0.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants