Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paul90/restrict #17

Merged
merged 9 commits into from
Sep 10, 2018
Merged

Paul90/restrict #17

merged 9 commits into from
Sep 10, 2018

Conversation

WardCunningham
Copy link
Member

@WardCunningham WardCunningham commented Aug 27, 2018 •
edited

First step towards login-to-view.
http://ward.asia.wiki.org/login-to-view.html

  • We accept --restricted parameter with no arguments to mean restricted to owner only.
  • We replace all .json requests with empty page titled "Login Required".

Login, logout and claim work to some degree. This is a foundation for improvements:

  • more specific restrictions
  • more careful security analysis
  • improve user experience

paul90
paul90 reviewed Sep 9, 2018
View reviewed changes
server/social.coffee Outdated Show resolved Hide resolved
@WardCunningham
Copy link
Member Author

This pull request is ready to be merged.

@paul90 paul90 merged commit 9c0bbad into master Sep 10, 2018
@paul90 paul90 deleted the paul90/restrict branch September 10, 2018 14:54
@paul90
Copy link
Member

paul90 commented Sep 10, 2018

Published as + wiki-security-passportjs@0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul90 paul90 paul90 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WardCunningham @paul90