Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial look at indicating if user is not the owner #19

Merged
merged 3 commits into from
Sep 23, 2018

Conversation

paul90
Copy link
Member

@paul90 paul90 commented Sep 16, 2018

this does not fully work as the server does not update isOwner in the client when the user authenticates.

this does not fully work as the server does not update `isOwner` in the client when the user authenticates.
@WardCunningham
Copy link
Member

We're making some subtle but important distinctions here. I see no problem going ahead if we are slow to provide accurate information. (Refresh to be sure.)

I'm more concerned that we are able to tell how we are logged in and what we can expect having done so. I offer some suggestions in a page of analysis: http://ward.asia.wiki.org/am-i-logged-in-yet.html

Lock icon should show unlocked only when authenticated and authorized. Authenticated but unauthorized should show tilted closed lock. Like neighbors, tilted means tried but didn't work. By analogy, lock could spin while authenticating.

Site ownership should show as "not yet owned", "owned by you" or "owned by name-or-id".

Hover over "owned by you" should show which account is the actual owner as one might have many

I'm getting multiple hovers over the lock. Hover text does not yet recognize login-to-view.

The key icon makes sense to me. "Grab the Key to Claim." Can we make this the only icon when a site is unowned and login will result in claim?

This is going to require some attention to make intuitive and consistent across all our security modules. Please don't think I am complaining.

@WardCunningham
Copy link
Member

I forgot to mention, I have installed this code merged with our other recent changes. This is certainly a step in the right direction.

lock remains closed, and rotated when logged in but not the wiki owner.
@WardCunningham WardCunningham merged commit cc410eb into master Sep 23, 2018
@WardCunningham
Copy link
Member

This and corresponding commit in wiki-client work together to meet cors expectations.
fedwiki/wiki-client#220

@paul90
Copy link
Member Author

paul90 commented Sep 23, 2018

Published as + wiki-security-passportjs@0.3.1

@paul90 paul90 deleted the paul90/not-owner branch September 23, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants