Tweet tests.

app/jobs/save_pages.rb

@@ -15,11 +15,13 @@ def perform(entry_id)
 
       key = FeedbinUtils.page_cache_key(url)
       begin
-        saved_pages[url] = Rails.cache.fetch(key) do
+        page = Rails.cache.fetch(key)
+        if !page
           Librato.increment 'readability.first_parse'
-          MercuryParser.parse(url)
+          page = MercuryParser.parse(url)
+          Rails.cache.write(key, page)
         end
-      rescue
+        saved_pages[url] = page.to_h
       end
 
       entry.data["saved_pages"] = saved_pages

app/models/mercury_parser.rb

@@ -41,6 +41,13 @@ def domain
     result['domain']
   end
 
+  def to_h
+    {
+      result: result,
+      url: url
+    }
+  end
+
   private
 
   def result
@@ -54,10 +61,7 @@ def result
   end
 
   def marshal_dump
-    {
-      result: result,
-      url: url
-    }
+    to_h
   end
 
   def marshal_load(data)

test/controllers/entries_controller_test.rb

@@ -37,6 +37,17 @@ class EntriesControllerTest < ActionController::TestCase
     assert_response :success
   end
 
+  test "should get show with tweet" do
+    entry = create_tweet_entry(@user.feeds.first)
+    url = "https://mercury.postlight.com/parser?url=https://9to5mac.com/2018/01/12/final-cut-pro-x-how-to-improve-slow-motion-in-your-projects-video/"
+    stub_request_file('parsed_page.json', url, headers: {"Content-Type" => "application/json; charset=utf-8"})
+    SavePages.new().perform(entry.id)
+
+    login_as @user
+    get :show, params: {id: entry}, xhr: true
+    assert_response :success
+  end
+
   test "should get content" do
     login_as @user
     content = Faker::Lorem.paragraph

test/jobs/save_pages_test.rb

@@ -0,0 +1,27 @@
+require 'test_helper'
+
+class SavePagesTest < ActiveSupport::TestCase
+
+  setup do
+    user = users(:ben)
+    @entry = create_tweet_entry(user.feeds.first)
+  end
+
+  test "should build" do
+    article_url = "https://9to5mac.com/2018/01/12/final-cut-pro-x-how-to-improve-slow-motion-in-your-projects-video/"
+    url = "https://mercury.postlight.com/parser?url=#{article_url}"
+    stub_request_file('parsed_page.json', url, headers: {"Content-Type" => "application/json; charset=utf-8"})
+
+    SavePages.new().perform(@entry.id)
+
+    saved_pages = @entry.reload.data["saved_pages"]
+    assert saved_pages.has_key?(article_url), "Entry should have saved page"
+    page = saved_pages[article_url]["result"]
+
+    %w{title author url date_published content domain}.each do |key|
+      assert page.has_key?(key), "page is missing #{key}"
+    end
+
+  end
+
+end

test/support/factory_helper.rb

@@ -35,4 +35,11 @@ def mark_unread(user)
       UnreadEntry.create_from_owners(user, entry)
     end
   end
+
+  def create_tweet_entry(feed)
+    entry = create_entry(feed)
+    entry.data["tweet"] = load_tweet
+    entry.save!
+    entry
+  end
 end