Improving stylesheets #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by improving the HiDPI @media query accordingly to: http://brettjankord.com/2012/11/28/cross-browser-retinahigh-resolution-media-queries/
Closed
|
Thanks. Yeah Autoprefixer sounds good. Bourbon could be removed entirely with Autoprefixer in place. |
| @if $media == ipad { | ||
| @media only screen and (max-width: 1024px) { @content; } | ||
| } @else if $media == hidpi { | ||
| @media only screen and (-webkit-min-device-pixel-ratio: $ratio), |
There was a problem hiding this comment.
Shouldn't this line be dedented by two spaces one level?
There was a problem hiding this comment.
Oh, my bad. Thanks for pointing that out. I’ll fix it as soon as I include Autoprefixer (#1).
This is not the only place in Feedbin stylesheets that could use some whitespace love, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to cherry-pick.
I was thinking about including Autoprefixer instead of using Bourbon for vendor-prefixed properties, but I don’t know if you’d like me to interfere as much.